Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download our own hyperkit driver if the installed one is missing or incompatible #3975

Closed
tstromberg opened this issue Mar 26, 2019 · 5 comments · Fixed by #5354
Closed

Download our own hyperkit driver if the installed one is missing or incompatible #3975

tstromberg opened this issue Mar 26, 2019 · 5 comments · Fixed by #5354
Assignees
@josedonizetti
Labels
co/hyperkit Hyperkit related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2 roadmap/2019 Items on the 2019 roadmap
Milestone
v1.5.0

Comments

@tstromberg
Copy link
Contributor

There are 3 implementations of docker-machine-driver-hyperkit, that all install to the same path:

  • The version that ships with Docker for Desktop
  • The machine-drivers fork (last updated in March 2018, which brew installs)
  • The minikube fork (last updated 19 days ago)

Any 3 of these versions may be an ancient and/or incompatible release with breaking bugs. Most hyperkit bugs are due to users not using the minikube fork. My rough idea is:

  • Upstream our hyperkit driver
  • Add versioning to the driver (binary --version)
  • If version is compatible, use it!
  • If the version is incompatible, fetch a new version into ~/.minikube and ask for sudo access to chmod it, and use it instead.
@tstromberg tstromberg mentioned this issue Mar 26, 2019
Closed
@tstromberg tstromberg added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Mar 26, 2019
@tstromberg tstromberg added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. r/2019q2 Issue was last reviewed 2019q2 and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Apr 4, 2019
@tstromberg tstromberg mentioned this issue Apr 4, 2019
Closed
@tstromberg tstromberg added the co/hyperkit Hyperkit related issues label May 22, 2019
@tstromberg
Copy link
Contributor Author

Related: #3939

@tstromberg tstromberg added the kind/feature Categorizes issue or PR as related to a new feature. label May 22, 2019
@tstromberg tstromberg added the roadmap/2019 Items on the 2019 roadmap label May 30, 2019
@tstromberg tstromberg mentioned this issue May 30, 2019
Closed
@josedonizetti josedonizetti mentioned this issue Jul 6, 2019
Closed
@sharifelgamal sharifelgamal added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jul 18, 2019
@josedonizetti
Copy link
Member

/assign @josedonizetti

@tstromberg tstromberg added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 6, 2019
@tstromberg tstromberg added this to the v1.4.0 Candidate milestone Aug 6, 2019
@tstromberg
Copy link
Contributor Author

Related - but not a blocker: #5180

@tstromberg
Copy link
Contributor Author

Will this land in time for the v1.4.0 release on Sep 16th?

@josedonizetti
Copy link
Member

josedonizetti commented Sep 4, 2019 •
edited
Loading

@tstromberg Yes, I'm returning to Brazil this weekend. I'll have my OSX to work on this.

@tstromberg tstromberg modified the milestones: v1.4.0, v1.5.0-candidate Sep 12, 2019
@josedonizetti josedonizetti mentioned this issue Sep 14, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josedonizetti josedonizetti

Labels
co/hyperkit Hyperkit related issues help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. r/2019q2 Issue was last reviewed 2019q2 roadmap/2019 Items on the 2019 roadmap
Projects
None yet
Milestone
v1.5.0
3 participants
@josedonizetti @tstromberg @sharifelgamal