Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support v1.Duration as a configuration type #1712

Closed
r2d4 opened this issue Jul 18, 2017 · 0 comments
Closed

Support v1.Duration as a configuration type #1712

r2d4 opened this issue Jul 18, 2017 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@r2d4
Copy link
Contributor

r2d4 commented Jul 18, 2017

"k8s.io/apimachinery/pkg/apis/meta/v1" is needed to set certain kube-proxy duration vars.

A cast needs to be added here https://github.com/kubernetes/minikube/blob/master/pkg/util/config.go#L71-L93

See #1158 (comment)
See #1699
@r2d4 r2d4 added kind/bug Categorizes issue or PR as related to a bug. localkube labels Jul 18, 2017
@r2d4 r2d4 mentioned this issue Jul 18, 2017
Closed
@r2d4 r2d4 changed the title Supper v1.Duration as a configuration type Support v1.Duration as a configuration type Jul 18, 2017
@r2d4 r2d4 mentioned this issue Jul 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@r2d4