Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit pull and tag and push to the minikube image command #12323

Closed
afbjorklund opened this issue Aug 21, 2021 · 1 comment · Fixed by #12326
Closed

Add explicit pull and tag and push to the minikube image command #12323

afbjorklund opened this issue Aug 21, 2021 · 1 comment · Fixed by #12326
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 21, 2021

These come in handy sometimes, for instance when testing. Currently included as part of other commands:

minikube image load --pull docker.io/my/image:v1.2.3

minikube image build --tag docker.io/my/image:latest --push

These are added to the cruntime API, and then exposed in the minikube image CLI for use in the tests.

@afbjorklund afbjorklund added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 21, 2021
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 21, 2021

Note that we still want "build" to handle it internally, to be able to support future features like multi-arch.

The original specification only allows for one architecture, so one can't use tags to handle manifests...

But BuildKit can handle multiple arch.

Might be a feature in Podman 4.0, too.

@afbjorklund afbjorklund added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant