Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start cri-docker service automatically, if using docker and kubernetes version >= 1.24 #12099

Closed
afbjorklund opened this issue Aug 2, 2021 · 8 comments · Fixed by #12102
Closed
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@afbjorklund
Copy link
Collaborator

afbjorklund commented Aug 2, 2021

As mentioned in #9868, using docker requires CRI starting from kubernetes 1.24 up:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2221-remove-dockershim

It is being casually updated by Mirantis, for use in their commercial products:

https://www.mirantis.com/blog/the-future-of-dockershim-is-cri-dockerd/

https://www.mirantis.com/blog/mirantis-to-take-over-support-of-kubernetes-dockershim-2/

We should make sure to include cri-dockerd, and switch to /var/run/cri-docker.sock


Most things should be prepared in the cruntime already.

Unfortunately it seems upstream doesn't provide binaries ?

> There is a Makefile with a few targets. make deb or make rpm will probably have you covered, and you can install the packages as normal. If you’re using a different distribution, make static will give you raw binaries you can invoke.

https://github.com/mirantis/cri-dockerd

@afbjorklund afbjorklund added co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Aug 2, 2021
@afbjorklund
Copy link
Collaborator Author

Moved packaging to #12103

@afbjorklund

This comment has been minimized.

@afbjorklund

This comment has been minimized.

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 13, 2021

The support status of cri-dockerd is unclear, looks like only Docker Desktop and Mirantis Kubernetes Engine gets support.

https://github.com/Mirantis/cri-dockerd/issues doesn't seem used at all

@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Aug 13, 2021

Unfortunately the dockershim is still included in v1.23.0-alpha.0, so now we have no idea when it will be removed (not 1.23).

https://kubernetes.io/blog/2020/12/02/dockershim-faq/#when-will-dockershim-be-removed

@afbjorklund
Copy link
Collaborator Author

It will be removed in 1.24 instead.

@afbjorklund

This comment has been minimized.

@afbjorklund afbjorklund changed the title Start cri-docker service automatically, if using docker and kubernetes version >= 1.23 Start cri-docker service automatically, if using docker and kubernetes version >= 1.24 Dec 10, 2021
@afbjorklund
Copy link
Collaborator Author

afbjorklund commented Dec 10, 2021

Still present in v1.24.0-alpha.0, but finally removed in v1.24.0-alpha.1.

Patches have been merged, so building CRI from master should be OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
co/runtime/docker Issues specific to a docker runtime kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant