The kicbase image downloads twice

[afbjorklund]

There is a regression in minikube 1.20.0, that the kicbase image will download twice: once to cache, once to daemon

The workaround is to do minikube start --download-only (or maybe docker pull), or to just let it download

The fix was in PR #11063

But it didn't make it to release

[afbjorklund]

Unfortunately it is still broken, so it will need some more update.

For some reason the cached image is failing to load load properly :

                        if err := image.LoadFromTarball(cc.Driver, img); err == nil {

Not sure why though, there was no logging but error doesn't make sense.

                i, err := tarball.ImageFromPath(p, &tag)
                if err != nil {
                        return errors.Wrap(err, "tarball")
                }

                _, err = daemon.Write(tag, i)
                return err

---

I0508 09:03:41.069981  273833 image.go:129] Checking for gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e in local cache directory
I0508 09:03:41.070006  273833 cache.go:137] Downloading gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e to local cache
I0508 09:03:41.070026  273833 profile.go:148] Saving config to /home/anders/.minikube/profiles/minikube/config.json ...
I0508 09:03:41.070030  273833 image.go:227] Writing gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e to local cache
    > gcr.io/k8s-minikube/kicbase...: 358.10 MiB / 358.10 MiB  100.00% 13.70 Mi
I0508 09:04:08.819632  273833 cache.go:140] successfully saved gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e as a tarball
I0508 09:04:08.819732  273833 cache.go:155] failed to load gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e, will try remote image if available: <nil>
I0508 09:04:08.819753  273833 cache.go:157] Downloading gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e to local daemon
I0508 09:04:08.819789  273833 image.go:289] Writing gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e to local daemon
    > gcr.io/k8s-minikube/kicbase...: 358.10 MiB / 358.10 MiB  100.00% 9.36 MiB
I0508 09:04:48.695034  273833 cache.go:159] successfully downloaded gcr.io/k8s-minikube/kicbase:v0.0.22@sha256:7cc3a3cb6e51c628d8ede157ad9e1f797e8d22a1b3cedc12d3f1999cb52f962e

Even with the logging, it was still <nil>

[afbjorklund]

It was using the wrong directory, ImageCacheDir instead of KICCacheDir

[apuppy]

Oh my my..., still got this error. download recursively. Can not perform minikube start.