From 5de590983adcdfed3bbcfcced7a79c612920c203 Mon Sep 17 00:00:00 2001 From: minikube-bot Date: Tue, 17 Jul 2018 15:11:44 +0000 Subject: [PATCH 1/8] Update releases.json to include v0.28.1 --- deploy/minikube/releases.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/deploy/minikube/releases.json b/deploy/minikube/releases.json index f07109c230ad..b20d58aa74e6 100644 --- a/deploy/minikube/releases.json +++ b/deploy/minikube/releases.json @@ -1,4 +1,12 @@ [ + { + "name": "v0.28.1", + "checksums": { + "darwin": "7d9b67c4c716184d6a854fb91b08b99094356a44b51e315659b254fbd74022cc", + "linux": "af261082d0ba9eb2dc3836a4cd903a449bafcb8647c5d5cb555c4e9144093627", + "windows": "e94d8d597e1c876dc45d6f63254e296bc95ee5c98c0a06b28050f59dad7d90c7" + } + }, { "name": "v0.28.0", "checksums": { From 7a7bd457f217f0f9e93e4d634cec447e24f6ef6b Mon Sep 17 00:00:00 2001 From: dlorenc Date: Tue, 17 Jul 2018 08:18:16 -0700 Subject: [PATCH 2/8] Fix the windows install upload. --- hack/jenkins/release_github_page.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/hack/jenkins/release_github_page.sh b/hack/jenkins/release_github_page.sh index 6a5c38cd57ea..2fb23950431a 100755 --- a/hack/jenkins/release_github_page.sh +++ b/hack/jenkins/release_github_page.sh @@ -115,6 +115,7 @@ FILES_TO_UPLOAD=( 'minikube-darwin-amd64' 'minikube-darwin-amd64.sha256' 'minikube-windows-amd64' + 'minikube-windows-amd64.sha256' 'minikube-installer.exe' "minikube_${DEB_VERSION}.deb" 'docker-machine-driver-kvm2' From 2dea4e1051818849ccf7bfbcecb79903c46043bf Mon Sep 17 00:00:00 2001 From: Dusty Rip Date: Sun, 15 Jul 2018 17:29:06 +0200 Subject: [PATCH 3/8] Allow zsh completion to be autoloaded by compinit --- cmd/minikube/cmd/completion.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cmd/minikube/cmd/completion.go b/cmd/minikube/cmd/completion.go index e0fa198686a7..580d887f2635 100644 --- a/cmd/minikube/cmd/completion.go +++ b/cmd/minikube/cmd/completion.go @@ -107,6 +107,8 @@ func GenerateBashCompletion(w io.Writer, cmd *cobra.Command) error { func GenerateZshCompletion(out io.Writer, cmd *cobra.Command) error { zsh_initialization := ` +#compdef minikube + __minikube_bash_source() { alias shopt=':' alias _expand=_bash_expand From 05f86aacfc995367d263dc25fdcfb22da964609e Mon Sep 17 00:00:00 2001 From: Rohit Agarwal Date: Thu, 19 Jul 2018 18:27:54 -0700 Subject: [PATCH 4/8] Bump minikube-nvidia-driver-installer version to make it work again. This incorporates the fix from GoogleCloudPlatform/container-engine-accelerators#85. That bug got exposed when we switched the kernel version from 4.16.14 to 4.15. --- deploy/addons/gpu/nvidia-driver-installer.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deploy/addons/gpu/nvidia-driver-installer.yaml b/deploy/addons/gpu/nvidia-driver-installer.yaml index ad5f2d0d3a9f..e5a03efc2017 100644 --- a/deploy/addons/gpu/nvidia-driver-installer.yaml +++ b/deploy/addons/gpu/nvidia-driver-installer.yaml @@ -50,7 +50,7 @@ spec: hostPath: path: / initContainers: - - image: k8s.gcr.io/minikube-nvidia-driver-installer@sha256:85cbeadb8bee62a96079823e81915955af0959063ff522ec01522e4edda28f33 + - image: k8s.gcr.io/minikube-nvidia-driver-installer@sha256:492d46f2bc768d6610ec5940b6c3c33c75e03e201cc8786e04cc488659fd6342 name: nvidia-driver-installer resources: requests: From 57e51f5921da100047f465e98226510a77dcd84d Mon Sep 17 00:00:00 2001 From: Kenji Kaneda Date: Fri, 20 Jul 2018 00:02:24 -0700 Subject: [PATCH 5/8] Fix a minor typo in docs/gpu.md ready to you -> ready to use --- docs/gpu.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/gpu.md b/docs/gpu.md index 5217a38fdd58..c5f57b02b33a 100644 --- a/docs/gpu.md +++ b/docs/gpu.md @@ -30,7 +30,7 @@ host to the minikube VM. Doing so has a few prerequisites: you want to passthrough to the VM and all other devices that are in the IOMMU group of these GPUs. -- Once you reboot the system after doing the above, you should be ready to you +- Once you reboot the system after doing the above, you should be ready to use GPUs with kvm2. Run the following command to start minikube: ``` minikube start --vm-driver kvm2 --gpu From 87d7a3208a1d09aa8ea2264e320e6e93c4b38605 Mon Sep 17 00:00:00 2001 From: Rohit Agarwal Date: Fri, 20 Jul 2018 07:23:09 -0700 Subject: [PATCH 6/8] Update KVM driver installation instructions. Move the latest instructions out of the comments and move old instructions into the comments. --- docs/drivers.md | 29 ++++++++++------------------- pkg/drivers/kvm/domain.go | 14 +++++--------- 2 files changed, 15 insertions(+), 28 deletions(-) diff --git a/docs/drivers.md b/docs/drivers.md index 767db0831ab3..87472b24a3a1 100644 --- a/docs/drivers.md +++ b/docs/drivers.md @@ -24,21 +24,17 @@ To install the KVM2 driver, first install and configure the prereqs: ```shell # Install libvirt and qemu-kvm on your system, e.g. -# Debian/Ubuntu (for Debian Stretch libvirt-bin it's been replaced with libvirt-clients and libvirt-daemon-system) -$ sudo apt install libvirt-bin qemu-kvm +# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system) +$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm # Fedora/CentOS/RHEL $ sudo yum install libvirt-daemon-kvm qemu-kvm -# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`) -$ sudo usermod -a -G libvirtd $(whoami) -# Fedora/CentOS/RHEL +# Add yourself to the libvirt group so you don't need to sudo +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ sudo usermod -a -G libvirt $(whoami) # Update your current session for the group change to take effect -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`) -$ newgrp libvirtd -# Fedora/CentOS/RHEL +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ newgrp libvirt ``` @@ -60,23 +56,18 @@ Minikube is currently tested against [`docker-machine-driver-kvm` v0.10.0](https After following the instructions on the KVM driver releases page, you need to make sure that have the necessary packages and permissions by following these instructions: ```shell - # Install libvirt and qemu-kvm on your system, e.g. -# Debian/Ubuntu (for Debian Stretch libvirt-bin it's been replaced with libvirt-clients and libvirt-daemon-system) -$ sudo apt install libvirt-bin qemu-kvm +# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system) +$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm # Fedora/CentOS/RHEL $ sudo yum install libvirt-daemon-kvm qemu-kvm -# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`) -$ sudo usermod -a -G libvirtd $(whoami) -# Fedora/CentOS/RHEL +# Add yourself to the libvirt group so you don't need to sudo +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ sudo usermod -a -G libvirt $(whoami) # Update your current session for the group change to take effect -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to `libvirt`) -$ newgrp libvirtd -# Fedora/CentOS/RHEL +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ newgrp libvirt ``` diff --git a/pkg/drivers/kvm/domain.go b/pkg/drivers/kvm/domain.go index 381b1610ccf6..142623d9cfb6 100644 --- a/pkg/drivers/kvm/domain.go +++ b/pkg/drivers/kvm/domain.go @@ -85,21 +85,17 @@ const connectionErrorText = ` Error connecting to libvirt socket. Have you set up libvirt correctly? # Install libvirt and qemu-kvm on your system, e.g. -# Debian/Ubuntu -$ sudo apt install libvirt-bin qemu-kvm +# Debian/Ubuntu (for older Debian/Ubuntu versions, you may have to use libvirt-bin instead of libvirt-clients and libvirt-daemon-system) +$ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm # Fedora/CentOS/RHEL $ sudo yum install libvirt-daemon-kvm qemu-kvm -# Add yourself to the libvirtd group (use libvirt group for rpm based distros) so you don't need to sudo -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to libvirt) -$ sudo usermod -a -G libvirtd $(whoami) -# Fedora/CentOS/RHEL +# Add yourself to the libvirt group so you don't need to sudo +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ sudo usermod -a -G libvirt $(whoami) # Update your current session for the group change to take effect -# Debian/Ubuntu (NOTE: For Ubuntu 17.04 change the group to libvirt) -$ newgrp libvirtd -# Fedora/CentOS/RHEL +# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` $ newgrp libvirt Visit https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm-driver for more information. From 9232e2630195d73ad548ff3c300c6fca76678599 Mon Sep 17 00:00:00 2001 From: dlorenc Date: Fri, 20 Jul 2018 11:07:42 -0700 Subject: [PATCH 7/8] Cut 0.28.2. --- CHANGELOG.md | 3 +++ Makefile | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6bd9e5c2a7c2..caba00b24e06 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Minikube Release Notes +# Version 0.28.2 - 7/20/2018 +* Nvidia driver installation fixed [#2996](https://github.com/kubernetes/minikube/pull/2986) + # Version 0.28.1 - 7/16/2018 * vboxsf Host Mounting fixed (Linux Kernel version downgraded to 4.15 from 4.16) [#2986](https://github.com/kubernetes/minikube/pull/2986) * cri-tools udpated to 1.11.1 [#2986](https://github.com/kubernetes/minikube/pull/2986) diff --git a/Makefile b/Makefile index 7704e555a88c..e433df2d2929 100755 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # Bump these on release VERSION_MAJOR ?= 0 VERSION_MINOR ?= 28 -VERSION_BUILD ?= 1 +VERSION_BUILD ?= 2 VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD) DEB_VERSION ?= $(VERSION_MAJOR).$(VERSION_MINOR)-$(VERSION_BUILD) INSTALL_SIZE ?= $(shell du out/minikube-windows-amd64.exe | cut -f1) From 23fc22e53264a961e08b1cb466b5c9d9616c1eee Mon Sep 17 00:00:00 2001 From: dlorenc Date: Mon, 23 Jul 2018 08:06:36 -0700 Subject: [PATCH 8/8] Fix docs for kvm2 --- pkg/drivers/kvm/domain.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/drivers/kvm/domain.go b/pkg/drivers/kvm/domain.go index 142623d9cfb6..ad361cd3d58c 100644 --- a/pkg/drivers/kvm/domain.go +++ b/pkg/drivers/kvm/domain.go @@ -91,11 +91,11 @@ $ sudo apt install libvirt-clients libvirt-daemon-system qemu-kvm $ sudo yum install libvirt-daemon-kvm qemu-kvm # Add yourself to the libvirt group so you don't need to sudo -# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` +# NOTE: For older Debian/Ubuntu versions change the group to [libvirtd] $ sudo usermod -a -G libvirt $(whoami) # Update your current session for the group change to take effect -# NOTE: For older Debian/Ubuntu versions change the group to `libvirtd` +# NOTE: For older Debian/Ubuntu versions change the group to [libvirtd] $ newgrp libvirt Visit https://github.com/kubernetes/minikube/blob/master/docs/drivers.md#kvm-driver for more information.