Allow components to generate certificates in-memory #69884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note
k8s-ci-robot
added
size/M
|
/kind bug |
k8s-ci-robot
added
kind/bug
liggitt
force-pushed
the
self-sign-in-memory
branch
2 times, most recently
from
540b1ba to
b087c65
Compare
sttts
reviewed
Oct 17, 2018
|
Looks good overall. One question. |
|
/retest |
liggitt
force-pushed
the
self-sign-in-memory
branch
from
b087c65 to
b7160d4
Compare
|
@sttts comments addressed |
sttts
reviewed
Oct 23, 2018
| @@ -282,15 +301,21 @@ func (s *SecureServingOptions) MaybeDefaultWithSelfSignedCerts(publicAddress str | |||
|
|
|||
| if cert, key, err := certutil.GenerateSelfSignedCertKeyWithFixtures(publicAddress, alternateIPs, alternateDNS, s.ServerCert.FixtureDirectory); err != nil { | |||
| return fmt.Errorf("unable to generate self signed cert: %v", err) | |||
| } else { | |||
| } else if len(keyCert.CertFile) > 0 && len(keyCert.KeyFile) > 0 { | |||
There was a problem hiding this comment.
can one be set and not the other?
There was a problem hiding this comment.
no, line 263 keeps us from getting here in that case.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @mikedanese @luxas |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, mikedanese, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Dec 4, 2018
* Remove controller-manager empty dir mount added for v1.12 kubernetes/kubernetes#68973 * No longer required kubernetes/kubernetes#69884
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Dec 4, 2018
* Remove controller-manager empty dir mount added for v1.12 kubernetes/kubernetes#68973 * No longer required kubernetes/kubernetes#69884
dghubble
added a commit
to poseidon/terraform-render-bootstrap
that referenced
this pull request
Dec 4, 2018
* Remove controller-manager empty dir mount added for v1.12 kubernetes/kubernetes#68973 * No longer required kubernetes/kubernetes#69884
This was referenced Mar 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows components to generate self-signed certificates in-memory if no certificate directory is specified. Defaults kube-controller-manager and cloud-controller manager to doing so.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #68973
Special notes for your reviewer:
Release note:
/assign @sttts