Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Cobra to version 1.3.0 #1166

Closed
brianpursley opened this issue Jan 19, 2022 · 2 comments · Fixed by kubernetes/kubernetes#108643
Closed

Update Cobra to version 1.3.0 #1166

brianpursley opened this issue Jan 19, 2022 · 2 comments · Fixed by kubernetes/kubernetes#108643
Assignees
@brianpursley
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@brianpursley
Copy link
Member

What would you like to be added:
Upgrade cobra from version 1.2.1 to 1.3.0

Why is this needed:
@brianpursley brianpursley added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 19, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 19, 2022
@brianpursley
Copy link
Member Author

/assign

@brianpursley brianpursley mentioned this issue Jan 19, 2022
Closed
@eddiezane eddiezane added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Feb 2, 2022
@k8s-ci-robot k8s-ci-robot removed the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Feb 2, 2022
@brianpursley
Copy link
Member Author

brianpursley commented Mar 4, 2022 •
edited
Loading

Update: We're waiting on a PR (for this issue spf13/cobra#1597) that splits cobra-cli (and its many related dependencies) from the core cobra library.

Once this is done, updating to the new version of cobra (it won't be 1.3.0... 1.4.x maybe?) should actually eliminate a lot of unnecessary dependencies in k/k.

@liggitt liggitt mentioned this issue Mar 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianpursley brianpursley

Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
3 participants
@eddiezane @brianpursley @k8s-ci-robot