Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split phase selfhosting convert-from-staticpods #735

Closed
mikebryant opened this issue Mar 22, 2018 · 3 comments
Closed

split phase selfhosting convert-from-staticpods #735

mikebryant opened this issue Mar 22, 2018 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@mikebryant
Copy link

Is this a BUG REPORT or FEATURE REQUEST?

Choose one: FEATURE REQUEST

Rationale

We want to use most of kubeadm, but supply our own self-hosted control plane at the end.

(In particular, we want to be masterless, with Deployments for the apiserver, controller-manager and scheduler, following from our current setup with bootkube)

The phases work great for most of this, however we only need one half of kubeadm alpha phase selfhosting convert-from-staticpods. We need the secret uploading part, but not the conversion from static pods.

Current workaround (for context)

kubeadm --config /etc/kubernetes/kubeadm.yaml alpha phase controlplane all
for component in apiserver controller-manager scheduler; do
  mv /etc/kubernetes/manifests/kube-${component}{,-custom}.yaml
done

...

kubeadm --config /etc/kubernetes/kubeadm.yaml alpha phase selfhosting convert-from-staticpods

...

apply our manifests

echo Waiting for self-hosted control plane to come online...
  for component in apiserver controller-manager scheduler; do
    while ! kubectl --namespace kube-system get pod -l k8s-app=kube-${component} -o wide | grep $(hostname); do
      sleep 5
    done
  rm /etc/kubernetes/manifests/kube-${component}-custom.yaml
done

Proposal

kubeadm alpha phase selfhosting upload-secrets
kubeadm alpha phase selfhosting convert-from-staticpods
@stealthybox
Copy link
Member

I can see why you want this, and I think it's a reasonable proposal 👍

@fabriziopandini
Copy link
Member

@mikebryant fyi there is a proposal for graduating phases in this cycle, and I think that the implementation of your proposal could take benefit from this effort as well. See
kubernetes/community#1939
kubernetes/kubernetes#61631

@timothysc timothysc self-assigned this Apr 5, 2018
@timothysc timothysc added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 5, 2018
@timothysc timothysc added this to the v1.11 milestone Apr 5, 2018
@timothysc
Copy link
Member

So I'm actually going to close this issue, b/c right now we are going to overhaul both phases and self-hosting in an effort to move to beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants