Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support printing addon manifests to STDOUT with a flag #2681

Closed
neolit123 opened this issue Apr 20, 2022 · 2 comments · Fixed by kubernetes/kubernetes#109995
Closed

support printing addon manifests to STDOUT with a flag #2681

neolit123 opened this issue Apr 20, 2022 · 2 comments · Fixed by kubernetes/kubernetes#109995
Assignees
@wangyysde
Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@neolit123
Copy link
Member

neolit123 commented Apr 20, 2022 •
edited
Loading

as discussed in:
#2680 (comment)
and comments above, it can be useful to allow kubeadm users to skip addons (already supported with kubeadm init --skip-phases=addons) but still be able to obtain the addon manifests that kubeadm will apply for version X.

then potentially patch them and apply them manually with kubectl.

proposing the following:

  • add a new common flag --print-manifest in kubeadm (or maybe use --dump-manifest?)
  • make the phases in kubeadm init phase addon {kube-proxy|coredns} support the flag.
  • if the flag is passed, kubeadm will not install the addon, instead kubeadm would print to STDOUT the manifests it is going to apply separated by --- - e.g. the coredns deployment, service objects etc.
@neolit123 neolit123 mentioned this issue Apr 20, 2022
Closed
@neolit123 neolit123 added this to the v1.25 milestone Apr 20, 2022
@neolit123 neolit123 added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/feature Categorizes issue or PR as related to a new feature. area/addons labels Apr 20, 2022
@neolit123
Copy link
Member Author

cc @voor

@wangyysde
Copy link
Member

I am try to do this .
/assign

@wangyysde wangyysde mentioned this issue May 12, 2022
Merged
@neolit123 neolit123 added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wangyysde wangyysde

Labels
area/addons kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add print-manifest flag to print addon manifests to STDOUT
2 participants
@neolit123 @wangyysde