Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: change the default imageRepository value for CI images #2356

Closed
neolit123 opened this issue Nov 30, 2020 · 4 comments · Fixed by kubernetes/kubernetes#97087
Closed

kubeadm: change the default imageRepository value for CI images #2356

neolit123 opened this issue Nov 30, 2020 · 4 comments · Fixed by kubernetes/kubernetes#97087
Assignees
@SataQiu
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v1.21

Comments

@neolit123
Copy link
Member

neolit123 commented Nov 30, 2020 •
edited
Loading

see kubernetes/test-infra#19483 (comment)
and kubernetes/k8s.io#1460

TL;DR if the kubeadm user passes a version that starts with ci* the image repository is defaulted to gcr.io/kubernetes-ci-images

this repository is being phased out in favor of gcr.io/k8-staging-ci-images

instead of making this an v1beta3 only change, i'm proposing that we default to the new URL in both old and new API versions.
@neolit123 neolit123 added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/feature Categorizes issue or PR as related to a new feature. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Nov 30, 2020
@neolit123 neolit123 added this to the v1.21 milestone Nov 30, 2020
@neolit123 neolit123 mentioned this issue Nov 30, 2020
Closed
@fabriziopandini
Copy link
Member

I think it is ok to change the default, given that we are just adapting to a change of URL in test infra

@spiffxp spiffxp mentioned this issue Dec 3, 2020
Closed
@SataQiu
Copy link
Member

SataQiu commented Dec 6, 2020

/assign

@SataQiu SataQiu mentioned this issue Dec 6, 2020
Merged
@neolit123
Copy link
Member Author

@SataQiu
i can see you sent the PR for k/k master already.
the change must be backported to all versions in the support skew (back to release-1.17) and release-1.20 as well.

@spiffxp should we execute on this now?

@neolit123
Copy link
Member Author

neolit123 commented Jan 21, 2021 •
edited
Loading

so given the change will become global in 1.21 we might want to backport this to the support skew:
kubernetes/kubernetes#97087

will send backports in a bit.

EDIT: done
kubernetes/kubernetes#98274
kubernetes/kubernetes#98275
kubernetes/kubernetes#98276

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SataQiu SataQiu

Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v1.21
3 participants
@neolit123 @fabriziopandini @SataQiu