Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceQuota labels #1951

Closed
oniram88 opened this issue Jan 14, 2023 · 4 comments · Fixed by #2175
Closed

ResourceQuota labels #1951

oniram88 opened this issue Jan 14, 2023 · 4 comments · Fixed by #2175
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@oniram88
Copy link

What would you like to be added:
Enable to get custom labels from ResourceQuota object with the
--metric-labels-allowlist command.
@oniram88 oniram88 added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 14, 2023
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 14, 2023
@dgrisonnet
Copy link
Member

/triage accepted
/help wanted

Hi @oniram88, would you be interested in contributing this feature to the project?

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 26, 2023
@oniram88
Copy link
Author

I'd like to but I can't write code in go. :-(

@a-hilaly
Copy link
Member

@dgrisonnet @oniram88 any guidance/examples to know what's needed to support this? i'd like to give it a shot

@opeco17 opeco17 mentioned this issue Aug 28, 2023
Merged
@opeco17
Copy link
Contributor

opeco17 commented Aug 28, 2023

I've created PR (#2175) to implement this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
5 participants
@oniram88 @a-hilaly @k8s-ci-robot @dgrisonnet @opeco17