From 93492226fb0d861fef3cf86c076406b3637c632f Mon Sep 17 00:00:00 2001 From: Peter Rifel Date: Sat, 18 Jan 2020 17:33:36 -0600 Subject: [PATCH] Prefix git tags with `v` Go modules require the v prefix [0], and k/k also tags with the v prefix [1] We have some inconsistent tags already, for 1.11.0 we have tags of both `1.11.0` and `v1.11.0` which is the most recent tag with the prefix. This is also why 1.11.0 is the default version imported by `go get`: ``` go get -v k8s.io/kops go: downloading k8s.io/kops v1.11.0 ``` and the latest version in `go list`: ``` go list -m -versions k8s.io/kops k8s.io/kops v1.4.0-alpha.1 v1.4.0 v1.4.1 v1.4.2 v1.4.3 v1.4.4 v1.10.0 v1.11.0 ``` I'm proposing we switch to only tagging with the v prefix. I'm only updating the actual git tag and not the entire version string used throughout kops due to its larger impact: * Output by `kops version` * Public URLs for kops assets * Protokube tag I'm hoping this is the least invasive way we can make this change. If we think advanced notice is required, we could tag with both formats for a number of releases before tagging only with the v prefix. [0] https://github.com/golang/go/wiki/Modules#modules [1] https://github.com/kubernetes/kubernetes/releases/tag/v1.17.0 --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 3d8a27db3e79d..555afd3f0c62e 100644 --- a/Makefile +++ b/Makefile @@ -585,10 +585,11 @@ ${CHANNELS}: .PHONY: release-tag release-tag: git tag ${KOPS_RELEASE_VERSION} + git tag v${KOPS_RELEASE_VERSION} .PHONY: release-github release-github: - shipbot -tag ${KOPS_RELEASE_VERSION} -config .shipbot.yaml + shipbot -tag v${KOPS_RELEASE_VERSION} -config .shipbot.yaml # -------------------------------------------------- # API / embedding examples