Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for new c5a AWS instance types #9281

Closed
coolstang opened this issue Jun 5, 2020 · 8 comments
Closed

Add Support for new c5a AWS instance types #9281

coolstang opened this issue Jun 5, 2020 · 8 comments
Assignees

Comments

@coolstang
Copy link

coolstang commented Jun 5, 2020

  • Add c5a AWS instance types to the supported list.

I can help with a PR if you like but I wouldn't know where to start to test and validate the change. The code does look trivial to update.

@coolstang coolstang changed the title Add Support for new c5a and c5ad AWS instance types Add Support for new c5a AWS instance types Jun 5, 2020
@coolstang
Copy link
Author

I have the needed changes on a local branch but make test is failing and I haven't determined why yet.

@johngmyers
Copy link
Member

It depends on what the failures are. You probably need to run hack/update-expected.sh.

@coolstang
Copy link
Author

I had the wrong go version installed so I adjusted it and build and tests now pass so I can put up the PR as soon as the feature request gets approved, and I complete the contributor process.

@coolstang
Copy link
Author

I have the work for this complete, can I get this item assigned to me so I can put up a MR?

@rifelpet
Copy link
Member

/assign @coolstang

though I should point out that we recently merged #8856 which removes the need for a hardcoded list of instance types. Those changes are in master (kops 1.19) so I think it would be best to have your PR target the release-1.18 branch so that we can add support for these types in kops 1.18. If there is anything special needed to handle these instance types beyond adding their entries to the large list of instance types, those special cases would need to be added to master in a separate PR.

@fred-vogt
Copy link

fred-vogt commented Jun 17, 2020

@coolstang, @rifelpet - I'd love this to be available in the 1.18.0 release.

AWS seems to be a bit behind schedule releasing these AMD instances:

If this gets into the 1.18 release branch I'd like to test c5a and c5ad instance types as possible kops masters.

I didn't know Use ec2.DescribeInstanceTypes for machine type info #8856 had landed.
This is great, this kind of testing with newly released instance types will be simpler in the future.

@coolstang
Copy link
Author

I'm going to put up a MR for 1.17 and 1.16 release branches as well.

@coolstang
Copy link
Author

Merged into 1.18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants