-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for new c5a AWS instance types #9281
Comments
I have the needed changes on a local branch but |
It depends on what the failures are. You probably need to run |
I had the wrong go version installed so I adjusted it and build and tests now pass so I can put up the PR as soon as the feature request gets approved, and I complete the contributor process. |
I have the work for this complete, can I get this item assigned to me so I can put up a MR? |
/assign @coolstang though I should point out that we recently merged #8856 which removes the need for a hardcoded list of instance types. Those changes are in master (kops 1.19) so I think it would be best to have your PR target the release-1.18 branch so that we can add support for these types in kops 1.18. If there is anything special needed to handle these instance types beyond adding their entries to the large list of instance types, those special cases would need to be added to master in a separate PR. |
@coolstang, @rifelpet - I'd love this to be available in the 1.18.0 release. AWS seems to be a bit behind schedule releasing these AMD instances:
If this gets into the 1.18 release branch I'd like to test I didn't know Use ec2.DescribeInstanceTypes for machine type info #8856 had landed. |
I'm going to put up a MR for 1.17 and 1.16 release branches as well. |
Merged into 1.18. |
I can help with a PR if you like but I wouldn't know where to start to test and validate the change. The code does look trivial to update.
The text was updated successfully, but these errors were encountered: