You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kubernetes/kubernetes#39551 added two flags to control the attach-detach reconcile sync in kube-controller-manager, attach-detach-reconcile-sync-period and disable-attach-detach-reconcile-sync, but only one of them got added to Kops in #1465.
We currently have the need to set disable-attach-detach-reconcile-sync, so I suggest adding disable-attach-detach-reconcile-sync as an option alongside attach-detach-reconcile-sync-period to Kops.
I can contribute the changes needed, if this sounds ok.
The text was updated successfully, but these errors were encountered:
Yes, feel free to open a PR! heres an example of a similar PR you can use as a reference. Essentially the field is added to pkg/apis/kops/v1alpha2/componentconfig.go and pkg/apis/kops/componentconfig.go and then you need to run make apimachinery crds.
kubernetes/kubernetes#39551 added two flags to control the attach-detach reconcile sync in kube-controller-manager,
attach-detach-reconcile-sync-period
anddisable-attach-detach-reconcile-sync
, but only one of them got added to Kops in #1465.We currently have the need to set
disable-attach-detach-reconcile-sync
, so I suggest addingdisable-attach-detach-reconcile-sync
as an option alongsideattach-detach-reconcile-sync-period
to Kops.I can contribute the changes needed, if this sounds ok.
The text was updated successfully, but these errors were encountered: