From 956ab3f61e800b4e759844b921cfb7917f8df722 Mon Sep 17 00:00:00 2001 From: Ole Markus With Date: Sun, 19 Jan 2020 13:06:15 +0100 Subject: [PATCH] Add Cilium.EnablePolicy back into templates This may have dropped out when we bumped Cilium to 1.6 It is possible to set this value in the cluster spec, but it isn't used anywhere --- .../addons/networking.cilium.io/k8s-1.12.yaml.template | 4 ++++ .../addons/networking.cilium.io/k8s-1.7.yaml.template | 4 ++++ upup/pkg/fi/cloudup/bootstrapchannelbuilder.go | 2 +- .../tests/bootstrapchannelbuilder/cilium/manifest.yaml | 4 ++-- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.12.yaml.template b/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.12.yaml.template index d1d101790ac7c..64fd97c95ba26 100644 --- a/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.12.yaml.template +++ b/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.12.yaml.template @@ -354,6 +354,10 @@ spec: key: custom-cni-conf name: cilium-config optional: true + {{ with .Networking.Cilium.EnablePolicy }} + - name: CILIUM_ENABLE_POLICY + value: {{ . }} + {{ end }} {{ with .Networking.Cilium }} image: "docker.io/cilium/cilium:{{ .Version }}" imagePullPolicy: IfNotPresent diff --git a/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.7.yaml.template b/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.7.yaml.template index daf7b13e6da55..d7cc314a0a4f6 100644 --- a/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.7.yaml.template +++ b/upup/models/cloudup/resources/addons/networking.cilium.io/k8s-1.7.yaml.template @@ -354,6 +354,10 @@ spec: key: custom-cni-conf name: cilium-config optional: true + {{ with .Networking.Cilium.EnablePolicy }} + - name: CILIUM_ENABLE_POLICY + value: {{ . }} + {{ end }} {{ with .Networking.Cilium }} image: "docker.io/cilium/cilium:{{ .Version }}" imagePullPolicy: IfNotPresent diff --git a/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go b/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go index 858bc4d8f4c7f..e36aa8319a434 100644 --- a/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go +++ b/upup/pkg/fi/cloudup/bootstrapchannelbuilder.go @@ -1117,7 +1117,7 @@ func (b *BootstrapChannelBuilder) buildAddons() *channelsapi.Addons { if b.cluster.Spec.Networking.Cilium != nil { key := "networking.cilium.io" - version := "1.6.4-kops.1" + version := "1.6.4-kops.2" { id := "k8s-1.7" diff --git a/upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/cilium/manifest.yaml b/upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/cilium/manifest.yaml index aebf9152f2274..e1e68e1dbaf68 100644 --- a/upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/cilium/manifest.yaml +++ b/upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/cilium/manifest.yaml @@ -119,7 +119,7 @@ spec: name: networking.cilium.io selector: role.kubernetes.io/networking: "1" - version: 1.6.4-kops.1 + version: 1.6.4-kops.2 - id: k8s-1.12 kubernetesVersion: '>=1.12.0' manifest: networking.cilium.io/k8s-1.12.yaml @@ -127,4 +127,4 @@ spec: name: networking.cilium.io selector: role.kubernetes.io/networking: "1" - version: 1.6.4-kops.1 + version: 1.6.4-kops.2