-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make proxy-real-ip-cidr a comma separated list #921
Make proxy-real-ip-cidr a comma separated list #921
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Coverage increased (+0.08%) to 44.391% when pulling 57aeafc281fafb9ea5963b7af97dc4f63bbccd38 on RemingtonReackhof:list-proxy-real-ip-cidr into 005ed52 on kubernetes:master. |
@RemingtonReackhof please sign the CLA |
@aledbf I am waiting for my organization to sign up so that I can sign it. I was told it will be by the end of the week or beginning of the next week, unfortunately. |
My organization and I have signed the CLA |
/lgtm |
@RemingtonReackhof thanks! |
Allows config maps to accept proxy-real-ip-cidr as a comma separated list like whitelist-source-range, e.g.
proxy-real-ip-cidr: "1.1.1.1/8,2.2.2.2/24"
This resolves #692