Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make proxy-real-ip-cidr a comma separated list #921

Merged
merged 1 commit into from
Jul 6, 2017
Merged

Make proxy-real-ip-cidr a comma separated list #921

merged 1 commit into from
Jul 6, 2017

Conversation

RemingtonReackhof
Copy link
Contributor

@RemingtonReackhof RemingtonReackhof commented Jun 28, 2017

Allows config maps to accept proxy-real-ip-cidr as a comma separated list like whitelist-source-range, e.g.

proxy-real-ip-cidr: "1.1.1.1/8,2.2.2.2/24"

This resolves #692

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 28, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 44.391% when pulling 57aeafc281fafb9ea5963b7af97dc4f63bbccd38 on RemingtonReackhof:list-proxy-real-ip-cidr into 005ed52 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Jun 29, 2017

@RemingtonReackhof please sign the CLA

@RemingtonReackhof
Copy link
Contributor Author

@aledbf I am waiting for my organization to sign up so that I can sign it. I was told it will be by the end of the week or beginning of the next week, unfortunately.

@RemingtonReackhof
Copy link
Contributor Author

My organization and I have signed the CLA

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 6, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 44.375% when pulling 1b3f0ac on RemingtonReackhof:list-proxy-real-ip-cidr into 6f64e81 on kubernetes:master.

@aledbf aledbf changed the title WIP: Make proxy-real-ip-cidr a comma separated list Make proxy-real-ip-cidr a comma separated list Jul 6, 2017
@aledbf aledbf self-assigned this Jul 6, 2017
@aledbf
Copy link
Member

aledbf commented Jul 6, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 6, 2017
@aledbf
Copy link
Member

aledbf commented Jul 6, 2017

@RemingtonReackhof thanks!

@aledbf aledbf merged commit b308be5 into kubernetes:master Jul 6, 2017
@RemingtonReackhof RemingtonReackhof deleted the list-proxy-real-ip-cidr branch July 7, 2017 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proxy-real-ip-cidr should be a list like whitelist-source-range
5 participants