Apply the 'ssl-redirect' annotation per-location #919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to avoid ingress definitions with different settings for SSL
redirection conflicting with each other.
NB: This was discussed in the review of #427, but ultimately not addressed.
In my test setup I have regular ingress definitions with enabled SSL-redirect, and kube-lego is adding '/.well-known/acme-challenge/...' ingress definitions that at least for a while need to not use ssl-redirection. In kube-lego's log files one can see the problem:
Note that the reachability test wants to use 'http' (see https://github.com/jetstack/kube-lego/blob/master/pkg/acme/cert_request.go#L47 for the request, and https://github.com/jetstack/kube-lego/blob/master/pkg/provider/nginx/nginx.go#L119 for the ingress configuration using ssl-redirect=false), but then follows the redirect to 'https' -- which uses the "Kubernetes Ingress Controller Fake Certificate".