Avoid reloads implementing Equaler interface #862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
aledbf
changed the title
|
Coverage decreased (-3.5%) to 42.961% when pulling 655176b8c369a5b46dc3624cd9463f2c75eb9dce on aledbf:equals into 245e6b0 on kubernetes:master. |
aledbf
changed the title
|
Out of curiosity why |
|
@jcmoraisjr no because with this change the slices are not sorted by IP |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduce two fixes:
The last change address the issue kubernetes-retired/contrib#1827
that was explained in a kubecon session https://www.youtube.com/watch?v=iShh33WaoHw
Basically if an ingress controller is scaled to more than 1 the previous behavior was to use the same order of the upstream servers in all the instances. With this PR we randomize the order.
fixes kubernetes-retired/contrib#1827