Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

could not build variables_hash #799

Closed
abh opened this issue May 31, 2017 · 3 comments
Closed

could not build variables_hash #799

abh opened this issue May 31, 2017 · 3 comments

Comments

@abh
Copy link

abh commented May 31, 2017

kube-lego by defaults add an annotation saying

ingress.kubernetes.io/whitelist-source-range: 0.0.0.0/0

this makes the nginx ingress controller add

geo $the_real_ip $deny_host1.example.com_/.well-known/acme-challenge {
    default 1;

    0.0.0.0/0 0;
}
geo $the_real_ip $deny_host2.example.com_/.well-known/acme-challenge {
    default 1;

    0.0.0.0/0 0;
}

which in turns makes the configuration fail with

2017/05/31 08:30:49 [warn] 58#58: duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:177
nginx: [warn] duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:177
2017/05/31 08:30:49 [warn] 58#58: duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:182
nginx: [warn] duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:182
2017/05/31 08:30:49 [warn] 58#58: duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:187
nginx: [warn] duplicate network "0.0.0.0/0", value: "0", old value: "1" in /tmp/nginx-cfg548829760:187
2017/05/31 08:30:49 [emerg] 58#58: could not build variables_hash, you should increase variables_hash_bucket_size: 64
nginx: [emerg] could not build variables_hash, you should increase variables_hash_bucket_size: 64
nginx: configuration file /tmp/nginx-cfg548829760 test failed

I tried with the latest beta and with quay.io/aledbf/nginx-ingress-controller:0.130. It looks like this was introduced in 07cdee5. The commit message doesn't say why the change was done.

@aledbf
Copy link
Member

aledbf commented May 31, 2017

The commit message doesn't say why the change was done.

This refactoring was required to get working the whitelist range when the controller is confiured with proxy protocol

@abh abh changed the title Crash with ingress.kubernetes.io/whitelist-source-range: 0.0.0.0/0 could not build variables_hash May 31, 2017
@abh
Copy link
Author

abh commented May 31, 2017

oh, now in the light of day: maybe the geo stuff is okay (just a warning that it's weirdly configured) and it's the variables_hash change - 8837cf9 - that made it croak.

@aledbf
Copy link
Member

aledbf commented Jun 2, 2017

Closing. Fixed in #809

@aledbf aledbf closed this as completed Jun 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants