Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76: hardcode X-Forwarded-Port due to SSL Passthrough #78

Closed
wants to merge 1 commit into from

Conversation

jgmize
Copy link

@jgmize jgmize commented Dec 22, 2016

No description provided.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 22, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 39.823% when pulling 7ef63fd on jgmize:fix-x-forwarded-port into f0762ba on kubernetes:master.

@jgmize
Copy link
Author

jgmize commented Dec 22, 2016

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 22, 2016
@jgmize
Copy link
Author

jgmize commented Dec 22, 2016

@aledbf I just saw that you had already assigned #76 to yourself; my apologies for any duplicate work. If you have a better fix in mind feel free to close this.

@aledbf
Copy link
Member

aledbf commented Dec 22, 2016

@jgmize sadly we cannot hard code the value. Please check #82

@aledbf aledbf closed this Dec 22, 2016
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants