Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for add_headers #730

Merged
merged 1 commit into from
Jul 10, 2017
Merged

Conversation

n1koo
Copy link

@n1koo n1koo commented May 18, 2017

Add support for add_headers globally. Uses similar pattern as custom proxy headers in #246 .

Could be taken further by adding support for annotations and adding this per location, but global is what our usecase needs right now

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 18, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@n1koo
Copy link
Author

n1koo commented May 18, 2017

CLA signed by having trouble linking it to GH, lets see if it worked now

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 46.994% when pulling 551410a8cce4f8c0a05a83aae5d42afd664dbf83 on n1koo:add_headers_support into b7bf783 on kubernetes:master.

@jonpulsifer
Copy link
Contributor

jonpulsifer commented Jul 10, 2017

@aledbf any opinions?
@n1koo can you see if you can get the CLA sorted out? that did it I guess

we're looking forward to this too 👍

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jul 10, 2017
@aledbf
Copy link
Member

aledbf commented Jul 10, 2017

@jonpulsifer this PR needs a rebase

@n1koo
Copy link
Author

n1koo commented Jul 10, 2017

Sorry about that, totally forgot this PR altogether. Rebased and CLA happy now :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 44.323% when pulling 02832de on n1koo:add_headers_support into c1e7c7a on kubernetes:master.

@aledbf aledbf self-assigned this Jul 10, 2017
@aledbf
Copy link
Member

aledbf commented Jul 10, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2017
@aledbf
Copy link
Member

aledbf commented Jul 10, 2017

@n1koo thanks!

@aledbf aledbf merged commit 9d08424 into kubernetes:master Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants