-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for add_headers #730
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
CLA signed by having trouble linking it to GH, lets see if it worked now |
Coverage decreased (-0.1%) to 46.994% when pulling 551410a8cce4f8c0a05a83aae5d42afd664dbf83 on n1koo:add_headers_support into b7bf783 on kubernetes:master. |
@jonpulsifer this PR needs a rebase |
551410a
to
02832de
Compare
Sorry about that, totally forgot this PR altogether. Rebased and CLA happy now :) |
/lgtm |
@n1koo thanks! |
Add support for add_headers globally. Uses similar pattern as custom proxy headers in #246 .
Could be taken further by adding support for annotations and adding this per location, but global is what our usecase needs right now