Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document passing of ssl_client_cert to backend #702

Merged
merged 2 commits into from
May 11, 2017

Conversation

tobilarscheid
Copy link
Contributor

this fixes #700

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 10, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@tobilarscheid
Copy link
Contributor Author

CLA is signed

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 10, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 47.139% when pulling 8d29610 on tobilarscheid:patch-1 into 317f222 on kubernetes:master.


## Which certificate was used for authentication?

In your backend application you might want to know which certificate was used for authentication. For this purpose, we pass the full certificate in PEM format to the backend in the `ssl_client_cert` header.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the header in template is ssl-client-cert and not ssl_client_cert.

@rikatz
Copy link
Contributor

rikatz commented May 10, 2017

@aledbf Just have to wait to correct the variable from ssl_client_cert to ssl-client-cert, and then LGTM :)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 46.983% when pulling 9c56c72 on tobilarscheid:patch-1 into 317f222 on kubernetes:master.

@rikatz
Copy link
Contributor

rikatz commented May 11, 2017

LGTM

@aledbf aledbf self-assigned this May 11, 2017
@aledbf
Copy link
Member

aledbf commented May 11, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2017
@aledbf
Copy link
Member

aledbf commented May 11, 2017

@tobilarscheid thanks!

@aledbf aledbf merged commit 335c473 into kubernetes:master May 11, 2017
@tobilarscheid tobilarscheid deleted the patch-1 branch May 11, 2017 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

passing of client certificate through header should be documented
6 participants