Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in generated nginx.conf for optional hsts-preload #685

Merged
merged 1 commit into from
May 4, 2017

Conversation

matjazp
Copy link
Contributor

@matjazp matjazp commented May 4, 2017

With PR #563 a trailing space is rendered in nginx.conf for optional HSTS preload option (false by default):

more_set_headers                        "Strict-Transport-Security: max-age=15724800; includeSubDomains; ";

Error

This brakes some clients, e.g. very popular HTTP2 Python hyper-h2 with:

h2.exceptions.ProtocolError: Received header value surrounded by whitespace b'max-age=15724800; includeSubDomains; '

Fix

This PR fixes the trailing space and moves it before the optional value as " preload".

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 47.043% when pulling d402e16 on matjazp:fix-hsts-preload into bf5610d on kubernetes:master.

@matjazp
Copy link
Contributor Author

matjazp commented May 4, 2017

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 4, 2017
@aledbf aledbf self-assigned this May 4, 2017
@aledbf
Copy link
Member

aledbf commented May 4, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 4, 2017
@aledbf
Copy link
Member

aledbf commented May 4, 2017

@matjazp thanks!

@aledbf aledbf merged commit 45ba1c7 into kubernetes:master May 4, 2017
@matjazp matjazp deleted the fix-hsts-preload branch June 16, 2017 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants