Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go version to 1.8 #654

Merged
merged 1 commit into from
Apr 26, 2017
Merged

Update go version to 1.8 #654

merged 1 commit into from
Apr 26, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 26, 2017

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented Apr 26, 2017

@nicksardo is ok to update go version to 1.8 in travis?

.travis.yml Outdated
@@ -9,7 +9,7 @@ notifications:
email: true

go:
- 1.7
- 1.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be 1.8.1?

@nicksardo
Copy link
Contributor

Yes, I think updating the version is fine.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 46.247% when pulling e70b50b on aledbf:update-go into 201a109 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.232% when pulling 4af9746 on aledbf:update-go into 201a109 on kubernetes:master.

@aledbf aledbf merged commit 7deb1a2 into kubernetes:master Apr 26, 2017
@aledbf aledbf deleted the update-go branch May 1, 2017 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants