Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to force namespace isolation #599

Merged
merged 1 commit into from
Apr 15, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 13, 2017

fixes #597

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 46.136% when pulling 77c9f4e on aledbf:force-isolation into 03cae88 on kubernetes:master.

@gianrubio
Copy link
Contributor

@aledbf as I understand this PR it to completely isolate the ingress in a namespace. A proof of concept is to enable RBAC in a cluster and deny all "communication" between namespaces.

Following this idea, we should check the namespace of this args:

  • publishSvc
  • defaultSvc
  • configMap
  • tcpConfigMapName
  • udpConfigMapName

It'll be good to block passing both args watchNamespace and force-namespace-isolation because they conflict.

Another important test is to check if all the annotations are in the same namespace.
ex: ingress.kubernetes.io/auth-tls-secret: default/my-cert

@aledbf aledbf merged commit 0f9f082 into kubernetes:master Apr 15, 2017
@aledbf aledbf deleted the force-isolation branch April 16, 2017 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Force Namespace isolation
5 participants