Expand developer docs #54
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
bprashanth
force-pushed
the
devel_docs
branch
from
032fdb0
to
a3ad31b
Compare
|
|
||
| Build a local container image | ||
| ```console | ||
| $ make container |
There was a problem hiding this comment.
PREFIX= and TAG= needs to be set here too.
|
|
||
| Push the container image to a remote repository | ||
| ```console | ||
| $ make push TAG=0.0 PREFIX=$USER/ingress-controller |
There was a problem hiding this comment.
It's TAG= in the current makefiles
There was a problem hiding this comment.
I think we'll have to udpate existing Makefiles for consistency, then update this doc with whiever convention we pick. Planning to do that in an iteration.
| $ go build -o godep *.go | ||
| ``` | ||
|
|
||
| If you have an older version of `go` |
There was a problem hiding this comment.
imo we should just assume the dev is using a new enough version of go and not provide instructions for older versions.
| $ GO15VENDOREXPERIMENT=1 godep save ./... | ||
| ``` | ||
|
|
||
| To update a particular dependency, eg: Kubernetes |
There was a problem hiding this comment.
These instructions are probably a little better: https://github.com/kubernetes/kubernetes/blob/master/docs/devel/godep.md#using-godep .. maybe we should link to em
At the very least, it's helpful to call out that a separate gopath is useful and that sometimes it's easiest to blow away both Godeps and vendor.
Also, rather than go get -u, it's often helpful to checkout a specific tag for a dependency, but I'm not sure it's worth calling that one out.
| @@ -3,7 +3,7 @@ all: push | |||
| BUILDTAGS= | |||
|
|
|||
| # 0.0 shouldn't clobber any release builds | |||
There was a problem hiding this comment.
that's saying if you want to push some test build to gcr to eg: test your write access, use 0.0. I suppose I can actually say that.
bprashanth
force-pushed
the
devel_docs
branch
from
a3ad31b
to
872c225
Compare
bprashanth
force-pushed
the
devel_docs
branch
from
872c225
to
939cb9c
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
can you post the error/log? |
|
I think I just had nginx running locally listening on the same ports. Maybe we can probe for 80/443 (lsof -i?) and throw an event? the controller was just dying mysteriously. |
Co-authored-by: clyang82 <[email protected]>
Following these instructions the nginx controller doesn't run on local-up-cluster, maybe I'm missing something obvious? plan to debug soon (it looks like it just hangs and doesn't start nginx), but I suppose we can iterate, since the doc captures intent.