Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nginx-ingress-controller is built twice by docker-build target #521

Merged
merged 1 commit into from
Mar 30, 2017

Conversation

porridge
Copy link
Member

porridge@kielonek:~/projects/go/src/k8s.io/ingress$ make test-e2e 
go get github.com/onsi/ginkgo/ginkgo
2017/03/30 12:38:12 e2e.go:276: Running: build-release
make[1]: Entering directory `/usr/local/google/home/porridge/projects/go/src/k8s.io/ingress'
make -C controllers/nginx build
make[2]: Entering directory `/usr/local/google/home/porridge/projects/go/src/k8s.io/ingress/controllers/nginx'
rm -f rootfs/nginx-ingress-controller
CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo \
                -ldflags "-s -w -X k8s.io/ingress/controllers/nginx/pkg/version.RELEASE=0.9.0-beta.3 -X k8s.io/ingress/controllers/nginx/pkg/version.COMMIT=git-e385c05 -X k8s.io/ingress/controllers/nginx/pkg/ve
[email protected]:porridge/ingress.git" \
                -o rootfs/nginx-ingress-controller k8s.io/ingress/controllers/nginx/pkg/cmd/controller
make[2]: Leaving directory `/usr/local/google/home/porridge/projects/go/src/k8s.io/ingress/controllers/nginx'
make -C controllers/nginx container
make[2]: Entering directory `/usr/local/google/home/porridge/projects/go/src/k8s.io/ingress/controllers/nginx'
rm -f rootfs/nginx-ingress-controller
CGO_ENABLED=0 GOOS=linux go build -a -installsuffix cgo \
                -ldflags "-s -w -X k8s.io/ingress/controllers/nginx/pkg/version.RELEASE=0.9.0-beta.3 -X k8s.io/ingress/controllers/nginx/pkg/version.COMMIT=git-e385c05 -X k8s.io/ingress/controllers/nginx/pkg/ve
[email protected]:porridge/ingress.git" \
                -o rootfs/nginx-ingress-controller k8s.io/ingress/controllers/nginx/pkg/cmd/controller
gcloud docker -- build --pull -t gcr.io/google_containers/nginx-ingress-controller:0.9.0-beta.3 rootfs
[...]

Seems to be a waste of time...

@porridge porridge changed the title nginx-ingress-controller is built twice by test-e2e nginx-ingress-controller is built twice by docker-build target Mar 30, 2017
@porridge
Copy link
Member Author

This is because the top-level docker-build target depends on controllers while the container target in controllers/nginx/Makefile also depends on build.

And there is a similarly superfluous dependency between docker-push and docker-build.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 30, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ed65647 on porridge:make-deps into ** on kubernetes:master**.

@aledbf aledbf self-assigned this Mar 30, 2017
@aledbf
Copy link
Member

aledbf commented Mar 30, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2017
@aledbf
Copy link
Member

aledbf commented Mar 30, 2017

@porridge thanks!

@aledbf aledbf merged commit 4ecb905 into kubernetes:master Mar 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants