Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in variable ProxyRealIPCIDR #52

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

gianrubio
Copy link
Contributor

I was running the default template for the ingress controller. I realised a typo in configuration, only renaming the var solve the issue.

Args

# ./nginx-ingress-controller 
--default-backend-service=kube-system/default-http-backend 
--tcp-services-configmap=kube-system/tcp-configmap 
--configmap=kube-system/nginx-load-balancer-conf

Error

...
W1212 13:18:13.925417      19 controller.go:833] service */* does not have any active endpoints
W1212 13:18:14.006342      19 queue.go:82] requeuing gitlab/kubedash, err template: nginx.tmpl:17:31: executing "nginx.tmpl" at <$cfg.ProxyRealIpCidr>: can't evaluate field **ProxyRealIpCidr** 
in type config.Configuration

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 12, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@gianrubio
Copy link
Contributor Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 39.753% when pulling bd9ec42 on gianrubio:typo-realipcidr into 697cf2d on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Dec 12, 2016

LGTM

@aledbf
Copy link
Member

aledbf commented Dec 12, 2016

@gianrubio thanks!

@aledbf aledbf merged commit 2ac8117 into kubernetes:master Dec 12, 2016
@gianrubio gianrubio deleted the typo-realipcidr branch February 22, 2017 21:49
hnrytrn pushed a commit to hnrytrn/ingress-nginx that referenced this pull request Jun 20, 2018
haoqing0110 referenced this pull request in stolostron/management-ingress Mar 5, 2021
Co-authored-by: Song Song Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants