-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Nginx] prometheus scrape annotations #471
[Nginx] prometheus scrape annotations #471
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA. Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
I signed it! |
@dannyk81 please squash the commits |
Allow Prometheus automatic discovery of nginx metrics endpoint Fixed kubernetes#464
97c4687
to
6a38a1a
Compare
@aledbf done, sorry about that 👍 |
/lgtm |
@dannyk81 thanks! |
My pleasure 😊 Thanks for merging this. |
This PR adds to the nginx
DaemonSet
andDeployment
examples annotations that are required for Prometheus automatic discovery and scraping of the nginx ingress controller/metrics
endpoint.This fixed #464