Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass request port to real server #454

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Conversation

danielqsj
Copy link
Contributor

What this PR does / why we need it:

If nginx ingress controller is behind some loadbalancer like haproxy, which redirect other port (not 80 or 443) to nginx ingress controller.
So request may looks like http://host:port. But nginx set Host and X-Forwarded-Host as $host, which without port like host. Therefore when real server send redirects to client requests, the url looks like http://host/redirect_url instead of correct url http://host:port/redirect_url.
If using $http_host instead of $host, the correct port will be passed to real server.

Which issue this PR fixes:

Closes #453

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.248% when pulling e3d320f021184d8a5c4723e5e5299aa19cac2cdd on danielqsj:master into 3d681cd on kubernetes:master.

@danielqsj danielqsj force-pushed the master branch 2 times, most recently from 0859def to fcb7ea9 Compare March 21, 2017 02:28
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.114% when pulling 43469a8 on danielqsj:master into 1739327 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 43.163% when pulling 43469a8 on danielqsj:master into 1739327 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.146% when pulling 43469a8 on danielqsj:master into 1739327 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 43.114% when pulling 43469a8 on danielqsj:master into 1739327 on kubernetes:master.

@aledbf aledbf self-assigned this Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2017
@aledbf
Copy link
Member

aledbf commented Mar 26, 2017

@danielqsj thanks!

@aledbf aledbf merged commit f521145 into kubernetes:master Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[nginx] Pass request port to real server
5 participants