Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nginx-tcp-and-udp on same port #450

Merged
merged 1 commit into from
Mar 15, 2017

Conversation

lkirill
Copy link
Contributor

@lkirill lkirill commented Mar 15, 2017

In nginx-ingress-controller if using

        - --udp-services-configmap=$(POD_NAMESPACE)/nginx-ingress-udp
        - --tcp-services-configmap=$(POD_NAMESPACE)/nginx-ingress-tcp

configs with same port, 53 for kube-dns as example:

apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-udp
data:
  53: "kube-system/kube-dns:53"

and

apiVersion: v1
kind: ConfigMap
metadata:
  name: nginx-ingress-tcp
data:
  53: "kube-system/kube-dns:53"

in nginx.conf will be created two upstreams with same name:

upstream kube-system-kube-dns-53 {...}

and nginx failing to start

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Mar 15, 2017
@aledbf
Copy link
Member

aledbf commented Mar 15, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 15, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.178% when pulling 23c4534 on lkirill:nginx-udp-and-udp-fix into 4f04537 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Mar 15, 2017

@lkirill thanks!

@aledbf aledbf merged commit 8a977cb into kubernetes:master Mar 15, 2017
@lkirill lkirill changed the title fix nginx-udp-and-udp on same port fix nginx-tcp-and-udp on same port Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants