Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix worker check issue #228

Merged
merged 1 commit into from
Feb 7, 2017
Merged

Fix worker check issue #228

merged 1 commit into from
Feb 7, 2017

Conversation

tangle329
Copy link
Contributor

Signed-off-by: Tang Le [email protected]

Signed-off-by: Tang Le <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 4, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.249% when pulling 008c47c on tangle329:master into 95d6900 on kubernetes:master.

@aledbf
Copy link
Member

aledbf commented Feb 4, 2017

@tangle329 why you change this? (the idea is to wait until the port 80 is available)

@tangle329
Copy link
Contributor Author

@aledbf After reading the code, I find this piece of code is waiting for the workers to exit and then start the new nginx process. So to check the exit status of worker should be wait until port 80 is not available, otherwise the new worker can be not started, because the port 80 is used by old one. Am i right ?

@aledbf aledbf self-assigned this Feb 7, 2017
@aledbf
Copy link
Member

aledbf commented Feb 7, 2017

@tangle329 you are right.

@aledbf
Copy link
Member

aledbf commented Feb 7, 2017

@tangle329 thanks!

@aledbf aledbf merged commit 4eb527d into kubernetes:master Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants