Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initialization of proxy variable #178

Merged
merged 1 commit into from
Jan 26, 2017
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 26, 2017

This change is to avoid setting the variable after any operation that can alter the process of the request (like a redirect)

@aledbf aledbf added the nginx label Jan 26, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.373% when pulling a8c92d591015d785cbcac7d7609cca895091081c on aledbf:proxy-name into 92ddc6c on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 44.373% when pulling 2baa1de on aledbf:proxy-name into 92ddc6c on kubernetes:master.

@aledbf aledbf assigned justinsb and unassigned justinsb Jan 26, 2017
@aledbf aledbf merged commit 87d4145 into kubernetes:master Jan 26, 2017
@aledbf aledbf deleted the proxy-name branch February 2, 2017 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants