Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the SSL Temp file to something inside the same SSL Directory #168

Merged
merged 1 commit into from
Jan 24, 2017

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Jan 24, 2017

This PR makes the following code changes:

When configuring SSL Certificate, instead of creating a new file on the 'OS Temp' directory, creates the file in the same SSL Certificates directory.

This is necessary when running ingress controller in bare metal. Having a different mount point to '/tmp' causes the ingress controller to hang, when trying to move/rename the file to the parsed one.

This is related to this PR: kubernetes-retired/contrib#2242

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.193% when pulling a930b29 on rikatz:tempdir into 74512c1 on kubernetes:master.

@aledbf aledbf self-assigned this Jan 24, 2017
@aledbf
Copy link
Member

aledbf commented Jan 24, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2017
@aledbf
Copy link
Member

aledbf commented Jan 24, 2017

@rikatz thanks!

@aledbf aledbf merged commit 40406b1 into kubernetes:master Jan 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants