add unit test cases for core.pkg.ingress.annotations.cors #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
aledbf
reviewed
Jan 22, 2017
| annotations map[string]string | ||
| expected bool | ||
| }{ | ||
| {map[string]string{"ingress.kubernetes.io/enable-cors": "true"}, true}, |
There was a problem hiding this comment.
please replace the keys "ingress.kubernetes.io/enable-cors" with the const annotation
There was a problem hiding this comment.
I've changed it, PTAL, thank you!
chentao1596
force-pushed
the
cors-unit-test
branch
from
a05d8ea
to
4bdc7d8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@chentao1596 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add unit test cases for core.pkg.ingress.annotations.cors, thank you!