Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose UDP port in UDP ingress example #1460

Merged
merged 1 commit into from
Oct 3, 2017
Merged

Conversation

chotiwat
Copy link
Contributor

@chotiwat chotiwat commented Oct 2, 2017

The port protocol in the nginx UDP loadbalancing example is not specified so it defaults to TCP.

The port protocol is not specified so it defaults to TCP
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Oct 2, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 2, 2017
@chotiwat
Copy link
Contributor Author

chotiwat commented Oct 2, 2017

Signed the CLA.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.578% when pulling da01583 on chotiwat:patch-1 into 923f4d4 on kubernetes:master.

@aledbf aledbf closed this Oct 2, 2017
@aledbf aledbf reopened this Oct 2, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 43.578% when pulling da01583 on chotiwat:patch-1 into 923f4d4 on kubernetes:master.

@chotiwat
Copy link
Contributor Author

chotiwat commented Oct 3, 2017

My bad, that was just a registration. It's signed now.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 3, 2017
@aledbf
Copy link
Member

aledbf commented Oct 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 3, 2017
@aledbf
Copy link
Member

aledbf commented Oct 3, 2017

@chotiwat thanks!

@aledbf aledbf merged commit 88e6af5 into kubernetes:master Oct 3, 2017
@chotiwat chotiwat deleted the patch-1 branch May 9, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants