Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate external names #1413

Merged
merged 1 commit into from
Sep 24, 2017
Merged

Validate external names #1413

merged 1 commit into from
Sep 24, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 24, 2017

fixes #1409

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 24, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 24, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 43.601% when pulling f8b213c on aledbf:resolve-external-names into 27d4e8b on kubernetes:master.

@aledbf aledbf merged commit e43641f into kubernetes:master Sep 24, 2017
@aledbf aledbf deleted the resolve-external-names branch September 26, 2017 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A bad ingress rule can break the controller
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot