Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reuse port and backlog to port 80 and 443 #141

Merged
merged 1 commit into from
Jan 19, 2017
Merged

Add reuse port and backlog to port 80 and 443 #141

merged 1 commit into from
Jan 19, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 19, 2017 •
edited
Loading

https://nginx.org/en/docs/stream/ngx_stream_core_module.html#listen

reuseport and backlog are already present in the config but only for port 18080

@aledbf aledbf self-assigned this Jan 19, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf
Copy link
Member Author

aledbf commented Jan 19, 2017

@foolusion thanks for the report

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.563% when pulling 7fa5aec on aledbf:fix-backlog into 28c6725 on kubernetes:master.

@aledbf aledbf assigned justinsb and unassigned aledbf Jan 19, 2017
justinsb
justinsb approved these changes Jan 19, 2017
View reviewed changes
Copy link
Member

@justinsb justinsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinsb justinsb merged commit ac5b84c into kubernetes:master Jan 19, 2017
@aledbf
Copy link
Member Author

aledbf commented Jan 19, 2017

@justinsb thanks!

@aledbf aledbf deleted the fix-backlog branch January 20, 2017 21:17
@gianrubio gianrubio mentioned this pull request Mar 2, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb justinsb approved these changes

Assignees

@justinsb justinsb

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @k8s-reviewable @coveralls @justinsb @k8s-ci-robot