Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional headers when custom default backend is used #1246

Merged
merged 1 commit into from
Aug 26, 2017
Merged

Add additional headers when custom default backend is used #1246

merged 1 commit into from
Aug 26, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 25, 2017 •
edited
Loading

Additional available variables:

  • $namespace
  • $ingress_name
  • $service_name

fixes #1010

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 25, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 25, 2017
@aledbf aledbf mentioned this pull request Aug 25, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 43.818% when pulling a85cfd1 on aledbf:additional-headers into b791460 on kubernetes:master.

@aledbf aledbf merged commit 6d0243a into kubernetes:master Aug 26, 2017
@aledbf aledbf deleted the additional-headers branch August 26, 2017 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give access to Ingress/Service namespace and name in NGINX template
4 participants
@aledbf @k8s-reviewable @coveralls @k8s-ci-robot