Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update nginx.go: preformance improve #1138

Merged
merged 1 commit into from
Aug 16, 2017
Merged

update nginx.go: preformance improve #1138

merged 1 commit into from
Aug 16, 2017

Conversation

hzxuzhonghu
Copy link
Member

move hash calc code together and improve printDiff function

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 16, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 44.714% when pulling fb2ad65 on hzxuzhonghu:master into 7891ed6 on kubernetes:master.

@aledbf aledbf self-assigned this Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 16, 2017
@aledbf
Copy link
Member

aledbf commented Aug 16, 2017

@hzxuzhonghu thanks!

@aledbf aledbf merged commit 6438c9f into kubernetes:master Aug 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aledbf aledbf

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hzxuzhonghu @k8s-reviewable @coveralls @aledbf @k8s-ci-robot