Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude socket metrics #9770

Merged
merged 6 commits into from
Apr 11, 2023
Merged

Exclude socket metrics #9770

merged 6 commits into from
Apr 11, 2023

Conversation

domcyrus
Copy link
Contributor

What this PR does / why we need it:

Feature to remove potentially expensive prometheus socket metrics for example histograms like connect_duration_seconds.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #9738

How Has This Been Tested?

Added unit tests.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

NONE

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 21, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @domcyrus!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @domcyrus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 21, 2023
@k8s-ci-robot k8s-ci-robot requested a review from strongjz March 21, 2023 10:49
@domcyrus
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 21, 2023
@domcyrus domcyrus mentioned this pull request Mar 22, 2023
Closed
tao12345666333
tao12345666333 reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!
Looks good to me, could you please add an e2e test case for this?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 22, 2023
@domcyrus
Copy link
Contributor Author

@tao12345666333 I've added an e2e test case for metrics.

@tao12345666333
Copy link
Member

/assign

I have added this to my list, I will finish review ASAP

@domcyrus
Copy link
Contributor Author

@tao12345666333 just a friendly ping if you already had the time to look into this or if I could somehow help on it in some way?

tao12345666333
tao12345666333 reviewed Mar 31, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay.

internal/ingress/metric/collectors/socket.go Outdated Show resolved Hide resolved
@domcyrus
Copy link
Contributor Author

domcyrus commented Apr 4, 2023

Hi @tao12345666333, just a friendly reminder I hope you don't mind. Is there anything else I can help with this PR or anything I can do to help it being merged?

@tao12345666333
Copy link
Member

tao12345666333 commented Apr 4, 2023 •
edited
Loading

Don't worry, I have too many things to do. Feel free to ping me if I haven't dealt with it.

I have added this to my list and will finish it tomorrow.

@domcyrus
Copy link
Contributor Author

Hi @tao12345666333, just another friendly reminder. I hope this message doesn't annoy you but I'm still interested in figuring out whether I can help you in some way with this PR or if there is something else I can do.

tao12345666333
tao12345666333 reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: domcyrus, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4e8d0b5 into kubernetes:main Apr 11, 2023
@akhilesh-godi akhilesh-godi mentioned this pull request Jun 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OOM due to prometheus metrics excessive memory usage
3 participants
@domcyrus @k8s-ci-robot @tao12345666333