From 79296459ed58b257f4e0154436db6ee0ccf750b2 Mon Sep 17 00:00:00 2001 From: Jintao Zhang Date: Wed, 26 Jan 2022 22:22:30 +0800 Subject: [PATCH 1/2] chore: using go install misspell Signed-off-by: Jintao Zhang --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index ad2c8340d3..b1c90e0f1e 100644 --- a/Makefile +++ b/Makefile @@ -167,7 +167,7 @@ live-docs: ## Build and launch a local copy of the documentation website in http .PHONY: misspell misspell: ## Check for spelling errors. - @go get github.com/client9/misspell/cmd/misspell + @go install github.com/client9/misspell/cmd/misspell@latest misspell \ -locale US \ -error \ From b92e8cd1da17f6b25277552ac243a3fa929d093c Mon Sep 17 00:00:00 2001 From: Jintao Zhang Date: Wed, 26 Jan 2022 22:24:55 +0800 Subject: [PATCH 2/2] chore: fix typo Signed-off-by: Jintao Zhang --- docs/index.md | 2 +- docs/user-guide/nginx-configuration/annotations.md | 4 ++-- test/e2e/settings/namespace_selector.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/index.md b/docs/index.md index 2b35e7e01f..63afaa66d9 100644 --- a/docs/index.md +++ b/docs/index.md @@ -63,7 +63,7 @@ FIELDS: ``` -## What has caused this change in behaviour ? +## What has caused this change in behavior? There are 2 reasons primarily. diff --git a/docs/user-guide/nginx-configuration/annotations.md b/docs/user-guide/nginx-configuration/annotations.md index 2dacc5293c..57542f25f0 100755 --- a/docs/user-guide/nginx-configuration/annotations.md +++ b/docs/user-guide/nginx-configuration/annotations.md @@ -251,7 +251,7 @@ Client Certificate Authentication is applied per host and it is not possible to To enable, add the annotation `nginx.ingress.kubernetes.io/auth-tls-secret: namespace/secretName`. This secret must have a file named `ca.crt` containing the full Certificate Authority chain `ca.crt` that is enabled to authenticate against this Ingress. -You can further customize client certificate authentication and behaviour with these annotations: +You can further customize client certificate authentication and behavior with these annotations: * `nginx.ingress.kubernetes.io/auth-tls-verify-depth`: The validation depth between the provided client certificate and the Certification Authority chain. (default: 1) * `nginx.ingress.kubernetes.io/auth-tls-verify-client`: Enables verification of client certificates. Possible values are: @@ -944,4 +944,4 @@ metadata: listen 8000; proxy_pass 127.0.0.1:80; } -``` \ No newline at end of file +``` diff --git a/test/e2e/settings/namespace_selector.go b/test/e2e/settings/namespace_selector.go index 4fa28826a8..ea162d594c 100644 --- a/test/e2e/settings/namespace_selector.go +++ b/test/e2e/settings/namespace_selector.go @@ -98,7 +98,7 @@ var _ = framework.IngressNginxDescribe("[Flag] watch namespace selector", func() _, err = f.KubeClientSet.CoreV1().Namespaces().Update(context.TODO(), ns, metav1.UpdateOptions{}) assert.Nil(ginkgo.GinkgoT(), err, "labeling not matched namespace") - // update ingress to trigger reconcilation + // update ingress to trigger reconciliation ing, err := f.KubeClientSet.NetworkingV1().Ingresses(notMatchedNs).Get(context.TODO(), notMatchedHost, metav1.GetOptions{}) assert.Nil(ginkgo.GinkgoT(), err, "retrieve test ingress") if ing.Labels == nil {