Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small typo fix in deploy/README.md #2297

Closed
wants to merge 1 commit into from
Closed

Small typo fix in deploy/README.md #2297

wants to merge 1 commit into from

Conversation

AdamDang
Copy link
Contributor

@AdamDang AdamDang commented Apr 5, 2018

Fixing some small typos.

@AdamDang
Small typo fix in deploy/README.md
7504fb9 
Fixing some small typos.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AdamDang
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: bowei

Assign the PR to them by writing /assign @bowei in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 5, 2018
@codecov-io
Copy link

Codecov Report

Merging #2297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2297   +/-   ##
=======================================
  Coverage   37.31%   37.31%           
=======================================
  Files          71       71           
  Lines        5043     5043           
=======================================
  Hits         1882     1882           
  Misses       2876     2876           
  Partials      285      285

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd2bc91...7504fb9. Read the comment docs.

@AdamDang
Copy link
Contributor Author

AdamDang commented Apr 5, 2018

/assign @bowei

antoineco
antoineco reviewed Apr 17, 2018
View reviewed changes
deploy/README.md
@@ -88,7 +88,7 @@ $ minikube addons disable ingress
$ kubectl edit deployment nginx-ingress-controller -n ingress-nginx
```

edit the following section:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good candidate for merging with #2358.

@AdamDang AdamDang mentioned this pull request Apr 17, 2018
Closed
@antoineco antoineco mentioned this pull request Apr 17, 2018
Merged
3 tasks
@antoineco
Copy link
Contributor

Consolidated in referenced PR (ping @aledbf)

@aledbf
Copy link
Member

aledbf commented Apr 17, 2018

Closing.

@aledbf aledbf closed this Apr 17, 2018
@AdamDang AdamDang deleted the patch-1 branch May 1, 2018 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoineco antoineco antoineco left review comments

Assignees

@bowei bowei

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AdamDang @k8s-ci-robot @codecov-io @antoineco @aledbf @bowei