Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

superfluous logging when using ssl-passthrough #982

Closed
abh opened this issue Jul 16, 2017 · 4 comments
Closed

superfluous logging when using ssl-passthrough #982

abh opened this issue Jul 16, 2017 · 4 comments
Labels

Comments

@abh
Copy link

abh commented Jul 16, 2017

For an ingress configured with ssl-passthrough I have a TLS section (otherwise it didn't listen to port 443), but no secretName (because the secret isn't here...). Every few seconds the controller logs:

controller.go:1043] host xyz.example.com is listed on tls section but secretName is empty. Using default cert
@aledbf
Copy link
Member

aledbf commented Jul 16, 2017

@abh if you use ssl-passthrough you don't need the tls section. It's ok to not see a listen in port 443.

@aledbf
Copy link
Member

aledbf commented Jul 17, 2017

@abh I will remove this log in the next release

@aledbf aledbf removed the bug label Jul 17, 2017
@abh
Copy link
Author

abh commented Jul 21, 2017

Great, thank you. An alternative would be to log that the tls section is unnecessary/unused. :-)

@aledbf
Copy link
Member

aledbf commented Jul 27, 2017

Closing. Fixed in #1031

@aledbf aledbf closed this as completed Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants