Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated description about service-upstream? #7875

Closed
awx-fuyuanchu opened this issue Nov 3, 2021 · 4 comments · Fixed by #7972
Closed

Outdated description about service-upstream? #7875

awx-fuyuanchu opened this issue Nov 3, 2021 · 4 comments · Fixed by #7972
Assignees
Labels
area/docs kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@awx-fuyuanchu
Copy link

awx-fuyuanchu commented Nov 3, 2021

NGINX Ingress controller version (exec into the pod and run nginx-ingress-controller --version.): v0.41.2

Kubernetes version (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"21", GitVersion:"v1.21.2", GitCommit:"092fbfbf53427de67cac1e9fa54aaa09a28371d7", GitTreeState:"clean", BuildDate:"2021-06-16T12:59:11Z", GoVersion:"go1.16.5", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"19+", GitVersion:"v1.19.13-gke.1900", GitCommit:"ee714a7b695ca42b9bd0c8fe2c0159024cdcba5e", GitTreeState:"clean", BuildDate:"2021-08-11T09:19:42Z", GoVersion:"go1.15.13b5", Compiler:"gc", Platform:"linux/amd64"}
WARNING: version difference between client (1.21) and server (1.19) exceeds the supported minor version skew of +/-1

Environment:

  • Cloud provider or hardware configuration: GKE
  • OS (e.g. from /etc/os-release): COS
  • Kernel (e.g. uname -a): Linux gitlab 5.4.129+ Basic structure  #1 SMP Mon Jul 26 19:50:53 PDT 2021 x86_64 Intel(R) Xeon(R) CPU @ 2.80GHz GenuineIntel GNU/Linux
  • Install tools:
    • Please mention how/where was clsuter created like kubeadm/kops/minikube/kind etc.
  • Basic cluster related info:
    • kubectl version
    • kubectl get nodes -o wide

What happened:

The description about service-upstream in doc https://github.com/kubernetes/ingress-nginx/blob/main/docs/user-guide/nginx-configuration/annotations.md#service-upstream

This can be desirable for things like zero-downtime deployments as it reduces the need to reload NGINX configuration when Pods come up and down. 

But I think there is no need to reload NGINX configuration when Pods come up and down since dynamic backend configuration are enabled by default. The description maybe need an update.

What you expected to happen:

/kind bug

Many thanks for your great works.

@awx-fuyuanchu awx-fuyuanchu added the kind/bug Categorizes issue or PR as related to a bug. label Nov 3, 2021
@k8s-ci-robot
Copy link
Contributor

@FuyuanChu: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority labels Nov 3, 2021
@longwuyuan
Copy link
Contributor

/remove-king bug
/kind documentation
/area docs

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/docs labels Nov 3, 2021
@longwuyuan
Copy link
Contributor

/remove-kind bug

@k8s-ci-robot k8s-ci-robot removed the kind/bug Categorizes issue or PR as related to a bug. label Nov 3, 2021
@awx-fuyuanchu awx-fuyuanchu changed the title Outdated description abount ervice-upstream? Outdated description abount service-upstream? Nov 3, 2021
@awx-fuyuanchu awx-fuyuanchu changed the title Outdated description abount service-upstream? Outdated description about service-upstream? Nov 3, 2021
@kundan2707
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs kind/documentation Categorizes issue or PR as related to documentation. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants