Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional quote in log format #482

Closed
thomaspeitz opened this issue Mar 22, 2017 · 1 comment
Closed

Remove additional quote in log format #482

thomaspeitz opened this issue Mar 22, 2017 · 1 comment

Comments

@thomaspeitz
Copy link
Contributor

Hey Ho Community,

while writing a logstash grok pattern for nginx ingress controller i realized a bug in the log format in autogenerated nginx.conf

This line is generated in default:

log_format upstreaminfo '$remote_addr - [$proxy_add_x_forwarded_for] - $remote_user [$time_local] "$request" $status $body_bytes_sent "$http_referer" "$http_user_agent" $request_length $request_time [$proxy_upstream_name] $upstream_addr $upstream_response_length $upstream_response_time $upstream_status"';

From my point of view the quote after upstream_status is too much.

Unsure if i am right:
https://github.com/kubernetes/ingress/blob/master/controllers/nginx/pkg/config/config.go#L50

Greetings, Thomas

@aledbf
Copy link
Member

aledbf commented Mar 22, 2017

Closing. Fixed in #481

@aledbf aledbf closed this as completed Mar 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants