Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests: run inside a container? #4297

Closed
moolen opened this issue Jul 9, 2019 · 1 comment · Fixed by #4299
Closed

unit tests: run inside a container? #4297

moolen opened this issue Jul 9, 2019 · 1 comment · Fixed by #4299
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@moolen
Copy link
Contributor

moolen commented Jul 9, 2019

As a contributor, i either have to install the kubernetes server components (this is missing in the development docs) and put them into /usr/local/bin or comment out this line and set the env var by myself to run the tests.

os.Setenv("KUBEBUILDER_ASSETS", "/usr/local/bin")

Question:

Should we add install k8s server and put them into /usr/local/bin to the development docs or do we want to run the unit tests inside a container?

@moolen moolen changed the title getting started guide: missing unit tests: run inside a container? Jul 9, 2019
@aledbf aledbf added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 11, 2019
@aledbf
Copy link
Member

aledbf commented Jul 11, 2019

@moolen #4299 fixes this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants