Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for http2_max_requests #3028

Closed
derekperkins opened this issue Sep 3, 2018 · 0 comments · Fixed by #3029
Closed

Add support for http2_max_requests #3028

derekperkins opened this issue Sep 3, 2018 · 0 comments · Fixed by #3029

Comments

@derekperkins
Copy link
Contributor

I'm running some high volume gRPC requests through nginx and see a lot of this error: 'there is no connection available' and 'the connection is draining' when using nginx (linked issue grpc/grpc-go#2205)

The suggested workaround is When we set http2_max_requests 1000000, the possibility became very low. There are similar suggestions in the linked nginx ticket. https://trac.nginx.org/nginx/ticket/1250

The ConfigMap already supports http2-max-field-size and http2-max-header-size, so it should be relatively trivial to add support for http2-max-requests.
http://nginx.org/en/docs/http/ngx_http_v2_module.html#http2_max_requests

Honestly it'd probably be helpful for people to change the default when gRPC is enabled, but I understand that deviating from nginx defaults probably isn't the best choice for this repo. It'd be worth documenting with the gRPC example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant