Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Please make it possible to enable proxy_buffering #1972

Closed
ghost opened this issue Jan 24, 2018 · 1 comment · Fixed by #1998
Closed

Feature request: Please make it possible to enable proxy_buffering #1972

ghost opened this issue Jan 24, 2018 · 1 comment · Fixed by #1998
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@ghost
Copy link

ghost commented Jan 24, 2018

It seems like it might be beneficial to the reliability of an app we run if it was possible to enable the nginx setting proxy_buffering. This seems to be currently hard-coded off, I assume it wouldn't be that much work to make it available via configmap/annotation..

@ghost ghost changed the title Feature request: Please make it possible to enable proxy-buffering Feature request: Please make it possible to enable proxy_buffering Jan 24, 2018
@aledbf aledbf added enhancement help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jan 24, 2018
@diazjf
Copy link

diazjf commented Jan 28, 2018

Since proxy buffering is set at the location level as seen here: https://github.com/kubernetes/ingress-nginx/blob/master/rootfs/etc/nginx/template/nginx.tmpl#L831 then an annotation would be best in this case. It can also be scoped at the http level, then a config-map value is also a good idea.

See http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_buffering

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants